Description

This PR updates our network requests for full syncs to respect the setting for whether to use cellular data or not.

• First sync will always use cellular, regardless of the toggle.
• Subsequent full syncs will fail if the toggle is set to off, and there's no wifi.
• Incremental syncs are not affected by the setting.

The PR works for both the paginated endpoint approach, and the file download endpoint (which is feature flagged)

Test Steps

Testing is a little fiddly if you don't have an iPad with cellular (which I don't.) You can't test on a simulator

To handle this, I used my iPhone Pro Max, which can show POS if you change the POSTabVisibilityChecker.checkVisibility() function to remove the guard userInterfaceIdiom == .pad check.

Paginated endpoint API

1. Disable wifi
2. Log out and log back in again
3. Observe that the first sync works as expected
4. Navigate to POS settings > Catalog
5. Tap Refresh Catalog
6. Observe that the sync does not complete and errors are logged in the console mentioning cellular. We don't show these in the UI

File catalog API

When testing with the file-based catalog API, you'll need to enable the pointOfSaleCatalogAPI feature flag.
It's also helpful to update POSCatalogSyncCoordinator.performFullSyncIfApplicable(for:maxAge:regenerateCatalog:) to stop it constantly regenerating the catalog. This isn't essential, but can help speed up testing with large sites.

    fullSyncService.startFullSync(for: siteID,
                                                        regenerateCatalog: false,
                                                        allowCellular: allowCellular)

If you use the larger test stores, you'll also need to update the POSLocalCatalogEligibilityService.Constants.defaultCatalogSizeLimit to 100000 so that it's deemed eligible for local catalog.

1. Disable wifi
2. Log out and log back in again
3. Switch to a store which supports local catalog (e.g. largefuntesting.mystagingwebsite.com)
4. Observe that the first sync works as expected
5. Navigate to POS settings > Catalog
6. Tap Refresh Catalog
7. Observe that the sync does not complete and errors are logged in the console mentioning cellular. We don't show these in the UI

Tests performed

• First sync uses cellular on file endpoint with Dotcom login
• First sync uses cellular on file endpoint with site credentials login
• First sync uses cellular on legacy endpoints with Dotcom login
• First sync uses cellular on legacy endpoints with site credentials login
• Full sync does not use cellular cellular on file endpoint with Dotcom login when toggle off
• Full sync does not use cellular on file endpoint with site credentials login when toggle off
• Full sync does not use cellular on legacy endpoints with Dotcom login when toggle off
• Full sync does not use cellular on legacy endpoints with site credentials login when toggle off
• Full sync uses cellular on file endpoint with Dotcom login when toggle off
• Full sync uses cellular on file endpoint with site credentials login when toggle off
• Full sync uses cellular on legacy endpoints with Dotcom login when toggle off
• Full sync uses cellular on legacy endpoints with site credentials login when toggle off

Note that errors are not shown when the sync fails for this reason, generally speaking, because sync happens as a non-user process. We could show errors when it fails on tapping Refresh catalog, since that's user invoked, but I see that as outside the scope of this PR.

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.